shared-db #1717
shared-db #1717
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Linting Errors
- guides/deployment/shared-db.md:86 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:186 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:255 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:415 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:423 Fenced code blocks should have a language specified
Spelling Mistakes
- guides/deployment/shared-db.md:13:28 Unknown word "microserivces"
- guides/deployment/shared-db.md:38:40 Unknown word "Clound"
- guides/deployment/shared-db.md:56:30 Unknown word "esample"
- guides/deployment/shared-db.md:247:3 Unknown word "Authentification"
- guides/deployment/shared-db.md:287:43 Unknown word "asynchronious"
- guides/deployment/shared-db.md:384:4 Unknown word "authentification"
- guides/deployment/shared-db.md:398:29 Unknown word "earch"
- guides/deployment/shared-db.md:439:23 Unknown word "authentification"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Linting Errors
- guides/deployment/shared-db.md:90 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:190 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:259 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:419 Fenced code blocks should have a language specified
- guides/deployment/shared-db.md:427 Fenced code blocks should have a language specified
Spelling Mistakes
- guides/deployment/shared-db.md:42:40 Unknown word "Clound"
- guides/deployment/shared-db.md:60:30 Unknown word "esample"
- guides/deployment/shared-db.md:251:3 Unknown word "Authentification"
- guides/deployment/shared-db.md:291:43 Unknown word "asynchronious"
- guides/deployment/shared-db.md:388:4 Unknown word "authentification"
- guides/deployment/shared-db.md:402:29 Unknown word "earch"
- guides/deployment/shared-db.md:443:23 Unknown word "authentification"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Linting Errors
- guides/deployment/shared-db.md:271 Fenced code blocks should have a language specified
Spelling Mistakes
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Spelling Mistakes
- guides/deployment/shared-db.md:42:257 Unknown word "Addinital"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Spelling Mistakes
- guides/deployment/late-cut-microservices.md:55:5 Unknown word "Modulith"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
guides/deployment/with-shared-db.md
Outdated
| With that we're basically done with the setup of the collector project. At the end of the day, it's just another CAP project with some cds models in it, which we can handle as usual. We can test whether it all works as expected, for example, we can test-compile and test-deploy it to sqlite and hana, build it, and deploy it to the cloud as usual: | ||
|
|
||
| ```sh | ||
| cds db -2 sql |
There was a problem hiding this comment.
What is cds db about? And why is this step needed?
There was a problem hiding this comment.
This step is not needed -> it's just to show that it works just like you would use it in a standalone cap project... since these are not necessary steps, we put it inside a details block
There was a problem hiding this comment.
Thanks.
I've got cds-dk@8.8.1 and that doesn't know cds db. What does it do?
guides/deployment/with-shared-db.md
Outdated
|
|
||
| Assumed we want to create a composite application consisting of two or more micro services, each living in a separate GitHub repository, for example: | ||
|
|
||
| - https://github.com/capire/bookstore |
There was a problem hiding this comment.
None existing links - will be picked up by broken link checker?
Repos don't exist or are outdated - isn't this confusing?
Maybe start with cap-samples directly and add a details section for setting up a new project?
There was a problem hiding this comment.
Yes, either create the repos or describe some other way.
I think it's good to have this front and center (monorepo with submodules) as it would be the typical project setup.
We could have a script that copies the folders from cloud-cap-samples and keeps them up to date...
There was a problem hiding this comment.
Ideally there'd be a command like
git submodule add https://github.com/SAP-samples/cloud-cap-samples --folder bookstore
But there isn't as far as I'm aware. There seems to be some way to achieve something similar, but too complicated for a guide :D
guides/deployment/with-shared-db.md
Outdated
| ::: | ||
|
|
||
|
|
||
| ### Deployment as separate mta |
There was a problem hiding this comment.
shouldn't this be on the same heading level as All-in-one Deployment
Can we move it to the end of the guide and clearly mention, that it is an alternative approach? It's unclear that it's either one or the other
There was a problem hiding this comment.
Yes, my thoughts exactly - been wondering where it would be a good fit, let's do it like that
There was a problem hiding this comment.
Spelling Mistakes
- guides/deployment/microservices.md:85:13 Unknown word "commited"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
There was a problem hiding this comment.
Spelling Mistakes
- guides/deployment/microservices.md:85:13 Unknown word "commited"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
No description provided.