types wip #186
Draft
types wip #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katamartin
reviewed
Mar 18, 2025
src/button.tsx
Outdated
| if (prefix) { | ||
| prefixHover = { | ||
| '&:hover > #prefix-span > #prefix': { | ||
| color: hoverColor, | ||
| ...prefix.type.hover, | ||
| ...(prefix.type as any).hover, |
There was a problem hiding this comment.
Ooh I didn't realize we did this -- so odd! So maybe a weird case where casting to any is okay?
There was a problem hiding this comment.
Thinking about this a little more, and it seems like a little util in this file could be helpful to accomplish the same thing while being a little more explicit?
const hasCustomHover = (comp: any): comp is { hover: ThemeUIStyleObject } =>
!!comp?.hoverwhich you could then use for prefix and suffix like
...(hasCustomHover(prefix.type) ? prefix.type.hover : {}),
katamartin
reviewed
Mar 19, 2025
| members: AvatarProps[] | ||
| direction?: 'horizontal' | 'vertical' | ||
| align?: Alignment | Alignment[] | ||
| spacing?: SizeKey | ResponsiveStyleValue<number | string> |
There was a problem hiding this comment.
Ooh ResponsiveStyleValue is so handy!
katamartin
reviewed
Mar 19, 2025
src/button.tsx
Outdated
| @@ -172,7 +196,7 @@ const Button = ( | |||
| id='prefix-span' | |||
| sx={{ display: 'inline-block', ...prefixOffset }} | |||
| > | |||
| {prefix && prefix} | |||
| {clonedPrefix && clonedPrefix} | |||
There was a problem hiding this comment.
I know the change here is just a variable name update, but it seems like the && is not doing anything?
Suggested change
| {clonedPrefix && clonedPrefix} | |
| {clonedPrefix} |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.