Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Outlook and Windows Attachment issues, resolve merge conflict #183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MaxPMagee
Copy link

@MaxPMagee MaxPMagee commented Jun 30, 2021

This PR is based on work that @kacyn did for the original PR here
#65

This also supports attachments in Outlook within Android

@MaxPMagee MaxPMagee mentioned this pull request Jun 30, 2021
@bruscantini
Copy link

bruscantini commented Sep 2, 2021

Are there any drawbacks to using this change?
Can you explain it? Do all clients except Outlook have a non-null "attachment" option?
Thanks,

@MaxPMagee
Copy link
Author

Unfortunately, I was not the original author, I just resolved the merge conflicts that cropped up months after the original PR. As I say here, I need someone who is a domain expert to review it.
#65 (comment)

@bruscantini
Copy link

bruscantini commented Sep 3, 2021

@MaxPMagee gotcha! Upon checking his comments in that PR, I think the first change is just for cases where the email has an attachment. I guess Outlook needs that when sending an attachment.

The second change is absolutely necessary for Outlook to work. I've actually been using that change in my app for some time now. I just had to upgrade the lib recently so I've had to revisit it :)

@mars-lan
Copy link
Contributor

mars-lan commented Sep 3, 2021

@bruscantini I think you meant to tag @MaxPMagee not me?

@bruscantini
Copy link

Yup @mars-lan sorry about that one. It wasn't prefilling his username for me.

@project-sense
Copy link

Is anyone looking into it, facing issue with outlook. Body not rendering when isHtml is set to true

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants