-
-
Notifications
You must be signed in to change notification settings - Fork 90
Add support for form arrays #401
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
unlocomqx
wants to merge
3
commits into
ciscoheat:main
Choose a base branch
from
unlocomqx:multiple-forms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9b2fe36
to
37b7b93
Compare
When form.id is reassigned during Svelte's derived phase, ERR_SVELTE_UNSAFE_MUTATION is thrown. It's because it can lead to unexpected errors and possibly cause infinite loops
Thank you, do the latest commits fix the message problem, or is it something I have to take a closer look at? |
Yes, the each key fix resolved the messages issue Thank you |
Nice work, hopefully I can add this to the next release! |
I'll be glad to see it in any release if it's stable and doesn't cause any trouble :)) |
As mentioned in #396, this has to wait until later. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #396
Currently, it's not possible to add new forms after component init because life hooks functions are being called when a form is created
This PR moves calls to life hooks outside the
superForm
functionTest page
http://localhost:5173/v2/multiple-forms