Skip to content

Add ability limit write access to a subset of users #208

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ScreamingHawk
Copy link
Contributor

This wiki has been perfect for my use case sans the ability to supply a list of moderators who are the only people able to edit the wiki pages. So I added it.

This pull requests adds another configuration parameter authorization.moderatorsFile which takes a path to a YAML file. The YAML file can contain a list of usernames and/or emails of moderators. When this configuration parameter is supplied, users can only edit the wiki if they are on this list.

Example moderators file:

usernames:
  - 'developer'
  - 'moderator'
emails:
  - 'jingouser'

Related to #67. I agree with the "could blow out of scope" comment, so this implementation is an all or nothing solution when used.

This is an update to my previous pull request #205 using a branch so I can develop other enhancements without affecting this isolated pull request.

@claudioc
Copy link
Owner

Hi,

this is very interesting indeed. I just need to think for a moment about it before merging.

Thanks :)

@ScreamingHawk
Copy link
Contributor Author

ScreamingHawk commented May 18, 2017

Small addition for users using LDAP that allows moderators to be configured via LDAP roles.

This change does not require my other pull request for LDAP and works with or without it, and is ignore for users not using LDAP.

Updated README with example YAML file.

@ScreamingHawk ScreamingHawk force-pushed the moderators branch 2 times, most recently from 341bffc to acdcd84 Compare May 28, 2017 19:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants