Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Never use dangerous chars in passwords to avoid XML validation error #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piroor
Copy link
Member

@piroor piroor commented Feb 10, 2025

This is followup of #53.

Generated password is embedded into the template directly:

      content      = "<AutoLogon><Password><Value>${var.windows-password}</Value></Password><Enabled>true</Enabled><LogonCount>1</LogonCount><Username>${var.windows-username}</Username></AutoLogon>"

thus some characters <, > and & may cause XML validation error. This PR rejects those chars from generated passwords.

@piroor piroor requested a review from yashirot February 10, 2025 01:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant