chore(backend,express): Introduce treatPendingAsSignedOut option to getAuth
#5842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LauraBeatris
force-pushed
the
laura/orgs-621-sdk-introduce-treatpendingassignedout-option-across-sdk-3
branch
from
080f453 to
b81ca7e
Compare
🦋 Changeset detectedLatest commit: 17c8480 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LauraBeatris
force-pushed
the
laura/orgs-621-sdk-introduce-treatpendingassignedout-option-across-sdk-3
branch
from
b81ca7e to
3a2bd6c
Compare
LauraBeatris
force-pushed
the
laura/orgs-621-sdk-introduce-treatpendingassignedout-option-across-sdk-3
branch
from
3a2bd6c to
4d7ae6b
Compare
LauraBeatris
force-pushed
the
laura/orgs-621-sdk-introduce-treatpendingassignedout-option-across-sdk-3
branch
from
4d7ae6b to
4d75ad8
Compare
LauraBeatris
force-pushed
the
laura/orgs-621-sdk-introduce-treatpendingassignedout-option-across-sdk-3
branch
from
4d75ad8 to
17c8480
Compare
brkalow
approved these changes
May 12, 2025
| @@ -99,7 +99,14 @@ export function signedIn( | |||
| afterSignInUrl: authenticateContext.afterSignInUrl || '', | |||
| after#Url: authenticateContext.after#Url || '', | |||
| isSignedIn: true, | |||
| toAuth: () => authObject, | |||
| // @ts-expect-error The return type is intentionally overridden here to support consumer-facing logic that treats pending sessions as signed out. This override does not affect internal session management like handshake flows. | |||
There was a problem hiding this comment.
👀 Is it possible to adjust the type so we don't need this?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows passing
treatPendingAsSignedOuttogetAuthChecklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change