-
Notifications
You must be signed in to change notification settings - Fork 343
feat(backend): signal support for handshake nonce #5905
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 4c521d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for signaling the handshake nonce flow by including a query parameter.
- In handshake.ts, the query parameter SupportsHandshakeNonce is appended to the URL.
- In handshake.test.ts, corresponding tests ensure the parameter is correctly set in both regular and development modes.
- In constants.ts, a new constant for SupportsHandshakeNonce is added to support the new query parameter.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/backend/src/tokens/handshake.ts | Appends a new query parameter for handshake nonce support. |
packages/backend/src/tokens/tests/handshake.test.ts | Adds tests to validate the presence of the new query parameter. |
packages/backend/src/constants.ts | Introduces the SupportsHandshakeNonce constant to hold the parameter key. |
LGTM. So to be doubly clear: this indicates "nonce support", but FAPI still has the option to return 'optimized' payload in initial response, right? |
@jfoshee Yeah, this is just to signal to the API that it COULD send a handshake nonce |
Description
Send query string param to signal support for handshake nonce flow from current version of
@clerk/backend
Related: SDKI-979
Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change