fix(clerk-js): Call setActive after closing checkout drawer #5916
+61
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/clerk-js/src/ui/components/Checkout/useCheckout.ts # packages/clerk-js/src/ui/contexts/components/Plans.tsx
🦋 Changeset detectedLatest commit: d8ff554 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alexcarpenter
approved these changes
May 13, 2025
| })); | ||
| setState(s => { | ||
| const currentItem = s[`${name}Drawer`]; | ||
| // @ts-expect-error `__internal_PlanDetailsProps` does not accept `onClose` |
There was a problem hiding this comment.
Any strong reason it shouldn't have an onClose prop?
There was a problem hiding this comment.
Only reason is that we didn't need it. But when/if we or customers need it we can certainly add it.
octoper
approved these changes
May 14, 2025
anagstef
approved these changes
May 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change