-
Notifications
You must be signed in to change notification settings - Fork 253
Support multiple registries and repositories #248
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
@nouwaarom i can give this a try this afternoon (UTC-4) - I do not know of any clib packages hosted on Gitlab, do you have some instructions that I can use to try this stuff out? |
Okay, cool. I have been using a private gitlab instance to develop this. I will setup a small demo on gitlab.com now and add some instructions. |
I create a small demo. It can be found at https://gitlab.com/nouwaarom/clib-demo with some instructions in the readme. |
c12ef25
to
c063070
Compare
This is great! Fantastic work @nouwaarom! Thank you for putting this together. A PR this big may take some time to review, so please be patient with us. I will try to spend some time testing this out in the next few days. |
I am very excited for this! I am working through the changes locally now and have some initial notes: running
after moving the file, if I run,
we should probably have more helpful error messages after setting the personal access token in the I echo @stephenmathieson on being patient as this is a big change. Perhaps we can get some tests in this change too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope these suggestions make sense.
0c9b594
to
f0ab015
Compare
Yes, I think that adding some tests is a good idea. I am currently working on passing all current tests again because most of them still fail :) After that I will add some tests for the new functionality. What is the current strategy for writing tests? |
754ef31
to
0ba5693
Compare
44f40d7
to
b099c9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I haven't been more active here. Been super busy with my 9-5.
I just pulled this branch down and poked around a bit. I got a seg fault doing:
make
./clib-install sha1
Unfortunately I cleared my terminal buffer, so I don't have the logs 🤷
I then tried without cache and got an error:
/clib-install -c sha1
fetch : clibs/sha1:package.json
error : unable to fetch https://raw.githubusercontent.com/clibs/sha1/0.0.1/sha1.h
error : unable to fetch https://raw.githubusercontent.com/clibs/sha1/0.0.1/sha1.c
➜ clib git:(feature/multiple-registries) ✗
I figured it might be something with the sha1
package, so I tried another:
➜ clib git:(feature/multiple-registries) ✗ ./clib-install module
error : Unable to install package module
➜ clib git:(feature/multiple-registries) ✗
I'm not sure what's up, but I am unable to install
anything using this branch.
I'm on macOS btw, with:
cc -v
Apple clang version 12.0.0 (clang-1200.0.32.29)
Target: x86_64-apple-darwin20.3.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
Hi Stephen. I'm sorry to hear that you could not install those dependencies. The problem with module is that it is not listed in a registry. The registry is required to lookup where a package can be downloaded from. (gitlab or github). We could add a fallback to github.com but it is better to just add module to the registry IMHO. |
43e2af2
to
6ce2c5a
Compare
dff7bd8
to
8de9c05
Compare
8aa517e
to
fca0528
Compare
…es in clib-search
clib_secrets.json misc: Cleanup, add headers.
misc: Fix some problems codacy detected.
…bug with downloading packages from gitlab, move common definitinos to clib-settings
misc: Apply suggestions from code review Co-authored-by: Bruno Dias <dias.h.bruno@gmail.com>
…on other platforms as well.
…add build instructions, cleanup Readme.
public gitlab repositories misc: Cleanup, download from the correct version when downloading from gitlab.
…crets from a JSON file.
…are properly joined. Fixed some compiler warnings.
fca0528
to
eae186b
Compare
Towards fixing #105
In order to support multiple registries and be able to download packages from multiple sources I had to change quite a few things.
clib.json
in aregistries
item.clib_secrets.json
so that we can connect with private registries and repositoriesChanges
Readme.md
toBuilding.md
and add instructions for cross-compiling for windows (as it took me some time to figure this out)pthread
as that seems to work fine (after fixing the pthread detection script)Usage.md
Todo
clib_secrets.json