Skip to content

Fix memory leaks #337

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix memory leaks #337

wants to merge 2 commits into from

Conversation

0x41rtur
Copy link

No description provided.

@stephenmathieson
Copy link
Member

Thanks for the patch! Unfortunately tests are failing. Can you please look into that?

stephenmathieson
stephenmathieson requested changes May 15, 2025
View reviewed changes
src/common/clib-package.c Outdated
Comment on lines 393 to 394
if (error && pkg)
clib_package_free(pkg);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add this to the existing if (error) block:

if (error) {
  if (pkg) {
    clib_package_free(pkg);
    pkg = NULL;
  }
}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@0x41rtur
Copy link
Author

Thanks for the patch! Unfortunately tests are failing. Can you please look into that?

fix

@0x41rtur 0x41rtur closed this by deleting the head repository Jun 24, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x41rtur @stephenmathieson