[Codebridge] Add reset neighborhood button #65257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molly-moen
approved these changes
Apr 15, 2025
| @@ -30,14 +44,40 @@ const MiniAppPreview: React.FunctionComponent<MiniAppPreviewProps> = ({ | |||
| showMaximizeButton = true, | |||
| handleScaling, | |||
| }) => { | |||
| const {labConfig} = useCodebridgeContext(); | |||
| const {labConfig, levelProperties} = useCodebridgeContext(); | |||
| const [isDisabled, setIsDisabled] = useState(true); | |||
There was a problem hiding this comment.
can you rename this something like isResetButtonDisabled? In the context of the component isDisabled could mean the entire preview is disabled.
There was a problem hiding this comment.
Additionally, do we need both isDisabled and isReset? Can we just update isDisabled when we would update isReset and get the same effect?
There was a problem hiding this comment.
Yes - will rename and simplify. Thanks!
fisher-alice
commented
Apr 15, 2025
| @@ -23,7 +23,7 @@ This tests adds some customization to the output of unit tests, and has a functi | |||
|
|
|||
| ## Building a package | |||
| From the package folder containing `pyproject.toml`, run `uv build`. The generated `.whl` file will be in the `code-dot-org/dist` folder. | |||
| The generated `.whl` file can then be copied to [apps/lib/pyiodide](../../apps/lib/pyodide/). | |||
| The generated `.whl` file can then be copied to [apps/lib/pyodide](../../apps/lib/pyodide/). | |||
There was a problem hiding this comment.
Unrelated typo fix.
fisher-alice
commented
Apr 15, 2025
| }} | ||
| size={'xs'} | ||
| type={'tertiary'} | ||
| className={classNames(darkModeStyles.tertiaryButton)} |
There was a problem hiding this comment.
Removed custom style since we now use DSCO dark theme.
molly-moen
approved these changes
Apr 15, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a 'reset' button for the Neighborhood mini-app so that a user can reset the Neighborhood to its initial state before running the program again. This is especially helpful when there are assets on the neighborhood grid including paint buckets with the initial number of 'paints' at a particular coordinate.
Example:
The 'reset' button is initially disabled.
Once the user runs the program and the program has completed, the 'reset' button is enabled and includes a tooltip:
After update
Notice that if a user goes to a different Neighborhood level, that the 'reset' button is initially disabled.
Screen.Recording.2025-04-15.at.12.08.54.PM.mov
Links
jira
Slack thread confirming implementation with product/design
Testing story
I tested on
pythonlabneighborhood levels and onpythonlabstandalone projects.This does not have any impact on console levels.
Deployment strategy
Follow-up work
I will check with product to see if they'd like to implement this for
javalab.Privacy
Security
Caching
PR Checklist: