Aws s3 #2226
Open
Aws s3 #2226
+26
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mitigates CVE-2016-3714 (ImageTragick)
|
If we implement this:
|
This change uses S3 over SFTP for logos. Although it incurs a cost, it is more stable and will therefore result in fewer errors. Long-term, we should think about how long we hold logos for before we delete them
|
Getting the existing logos might be tricky. If I try to I get a 522 error |
|
Screenshot, just to show it's working: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a longer-term plan, but evidences that it is low-complexity to move to S3 for image storage.
Before this is merged, we have to: