Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addiescode-sj
approved these changes
May 9, 2025
| margin: 0; | ||
| padding: 0; | ||
| box-sizing: border-box; | ||
| } |
There was a problem hiding this comment.
5,6 라인 사이에 공백 한칸 띄워줄까요?
지금은 좋은 포맷팅 습관을 들이기위해 수동으로 고쳐보시고,
나중에 포맷팅을 자동화하는 도구를 사용해보시면 좋을것같네요!
아래 아티클에서 규칙들 정도만 참고해보세요 :)
| padding: 0; | ||
| box-sizing: border-box; | ||
| } | ||
| a ,a > button { |
There was a problem hiding this comment.
여기서도 이렇게!
Suggested change
| a ,a > button { | |
| a, a > button { |
| <div class="login-container"> | ||
| <div class="login-img-box"> | ||
| <a href="/" aria-label="홈으로 이동"> |
There was a problem hiding this comment.
접근성을 위해 aria-label을 써주셨네요! 굳굳 👍
| <div class="login-ezlogin-logos"> | ||
| <a href="https://www.google.com" aria-label="구글로 이동" rel="noopener"> | ||
| <img class="logo" src="./images/main-page/google-logo.png" alt=""> |
There was a problem hiding this comment.
귀찮더라도 접근성을 위해 img에 alt 태그는 꼭 사용해주시는게 좋아요.
아래 애플 공식 홈페이지 예시를 보면 굉장히 세세하게 잘 사용해준 모습을 볼 수 있습니다 :)
<img src="/v/macbook-pro/aq/images/overview/themes/battery/battery_hero__d5zgrstiu9si_xlarge.jpg" onload="__lp(event)" alt="깜깜한 밤, 야외에서 삼각대에 장착한 카메라를 별이 가득한 하늘을 향해 놓은 채 카메라에 연결한 MacBook Pro를 무릎에 올려놓고 작업 중인 사람의 모습">There was a problem hiding this comment.
sprint2에서부터 다음 미션 코드가 있네요! 미션별 요구사항마다 리뷰를 다르게 드려볼게요
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
-로그인, 회원가입 페이지 추가
스크린샷
https://sprightly-frangollo-6428dc.netlify.app/
멘토에게