Skip to content

[임채민] Week9 #771

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: part2-임채민
Choose a base branch
from
Open

[임채민] Week9 #771

wants to merge 1 commit into from

Conversation

Chaemin-153
Copy link
Collaborator

멘토에게

  • 9주차는 한 것이 많이 없습니다 ㅜ
  • 저번 주차에 Folder 페이지에서 Card 데이터 보이는 게 되지 않았어서 이 부분 수정했습니다

@Chaemin-153 Chaemin-153 requested a review from Lennon57 February 26, 2024 04:24
@Chaemin-153 Chaemin-153 self-assigned this Feb 26, 2024
@Chaemin-153 Chaemin-153 added the 미완성 죄송합니다.. label Feb 26, 2024
Lennon57
Lennon57 reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@Lennon57 Lennon57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 채민님!
프로젝트 화이링~!

src/components/Folder/FolderCategory.js
Comment on lines -13 to -14
<>
<TitleWrapper>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

src/hooks/useFetchFolderCardsData.js
fetchData();
}, [folderId]);

return cardsData;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return도 객체로 작성하면, 사용처들에서 똑같은 변수로 받을 수 있어서 좋아요!

return {
  cardDatas,
}

// or

return {
  data: cardDatas,
}

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Lennon57 Lennon57 Lennon57 approved these changes

Assignees

@Chaemin-153 Chaemin-153

Labels
미완성 죄송합니다..
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaemin-153 @Lennon57