Skip to content

Fix audio playback within Simulator. #3551

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LevittS
Copy link

@LevittS LevittS commented Feb 4, 2022

Spent some time working out why it wouldn't work- this seems to for me.

@shai-almog shai-almog requested a review from shannah February 5, 2022 05:41
@shannah
Copy link
Collaborator

shannah commented Feb 7, 2022

Thanks for the pull request. Can you provide a test case that this fixes for you. I seem to recall that using https:// (rather than a custom scheme) solved a lot of issues with webpage loading in CEF. My original implementation used the custom scheme (like you change it to here) but I had to change it because of problems (I don't remember specifics).
If you can provide a test case, it will help me work with your pull request to fix it for all cases.

@LevittS
Copy link
Author

LevittS commented Feb 7, 2022

I couldn't get any audio to work without changing something - just single createMedia calls followed by play regardless of the source of the InputStream weren't working for me - I was seeing network errors in the CEF browser console (a bit like cn1app wasn't a valid hostname).
I'm away from my machine at the moment, and could provide some actual code later, but it was basically the same as the example code I could find.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants