-
Notifications
You must be signed in to change notification settings - Fork 42
feat: support start-tunnel over Wi-Fi #21
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Conversation
为什么要支持WiFi呀,也特定没支持的,因为觉得这个wifi又慢又不稳定 |
没办法,我们有这个需求 |
tidevice3/cli/tunneld.py
Outdated
"""return list of udid""" | ||
try: | ||
devices = list_devices(usb=True, network=False) | ||
usb_devices = list_devices(usb=True, network=False) | ||
devices = ["usb_" + d.Identifier for d in usb_devices if Version(d.ProductVersion) >= Version("17")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里感觉不太好,udid加上前缀 usb_, wifi_ 感觉不如直接定义一个新的类型,比如
get_connected_devices(usb: bool, network: bool) -> List[DeviceInfo]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
以提交新版本
tidevice3/cli/tunneld.py
Outdated
start_tunnel_cmd = "lockdown" | ||
cmdargs = pmd3_path + f"{start_tunnel_cmd} start-tunnel --script-mode --udid {udid}".split() | ||
lockdown_devices = get_need_lockdown_devices() | ||
if device_type == "wifi" and _udid not in lockdown_devices: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
=17.0 < 17.4 的设备不包含这这里面?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
17.4以下,Wi-Fi模式,用remote加-t wifi;17.4以上,Wi-Fi模式和USB模式都用lockdown,没有-t wifi选项
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 56.42% 55.58% -0.85%
==========================================
Files 18 18
Lines 911 905 -6
Branches 101 106 +5
==========================================
- Hits 514 503 -11
- Misses 393 398 +5
Partials 4 4 ☔ View full report in Codecov by Sentry. |
请教下大佬如何使用wifi连接呢,pymobiledevice3的文档有点看不懂,目前
|
首先确保设备通过Wi-Fi连接好了,t3 list -n可以看到设备。 |
No description provided.