Use yaml.dump over old dump command, stripped double .cwl, and fixed import issues #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
force-pushed
the
bugfix/fix-cwl-graph-split
branch
from
7584f8a to
c903624
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
+ Coverage 34.33% 34.53% +0.20%
==========================================
Files 30 30
Lines 35362 35375 +13
Branches 9553 9555 +2
==========================================
+ Hits 12142 12218 +76
+ Misses 20327 20269 -58
+ Partials 2893 2888 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…imports Added cwlformat to requirements (needed for --pretty parameter), Co-authored-by: Michael R. Crusoe <crusoe@debian.org>
mr-c
force-pushed
the
bugfix/fix-cwl-graph-split
branch
2 times, most recently
from
a2aa6eb to
4736b18
Compare
mr-c
force-pushed
the
bugfix/fix-cwl-graph-split
branch
from
4736b18 to
c9ac6c3
Compare
mr-c
reviewed
Apr 23, 2025
| @@ -5,3 +5,4 @@ requests | |||
| schema-salad >= 8.8.20250205075315,<9 | |||
| ruamel.yaml >= 0.17.6, < 0.19 | |||
| typing_extensions;python_version<'3.10' | |||
| cwlformat >= 2022.2.18 | |||
There was a problem hiding this comment.
No, this is brought in the the extra pretty; we don't want to require all users of cwl-utils to install cwlformat.
Suggested change
| cwlformat >= 2022.2.18 |
There was a problem hiding this comment.
Can you elaborate on this please? It's been a while since I actually put in the PR.
Why don't we want cwlformat as a requirement?
What do you mean by the extra 'pretty'?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added cwlformat to requirements (needed for --pretty parameter),
Resolves #285
Resolves #286