Skip to content

Flow #4

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from
Draft

Flow #4

wants to merge 35 commits into from

Conversation

ecisneros8
Copy link
Collaborator

@ecisneros8 ecisneros8 commented Jan 8, 2021

This PR adds code that allows PyQBMM to solve moment transport equations in one spatial dimension. The principal changes are:

  • A new simulation_domain class to discretize spatial domains. This class provides fluxes and source terms to the advancer.
  • The advancer no longer owns a qbmm_mgr. Instead, it owns a simulation_domain, from which it gets any information on the moments and quadratures.
  • The advancer can only handle such problems through its Euler method.
  • The driving case is the 1D crossing-jet problem of Yuan & Fox [J. Comp. Phys. (2011)]. It's config is hard-coded, for now, in devel_driver.py, though a corresponding yaml file will follow soon.
  • A MATLAB code from Fox's group has been used to guide development. It has been used to visually inspect and compare fluxes. The MATLAB code uses a RK2 time-stepping scheme, though there are no planned efforts to incorporate it into PyQBMM.

Note: this is a draft PR. It will be ready for review upon verification of the 1D crossing jet problem.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants