Proof-of-concept: desktop navbar #260
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compilerla ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is just a rough proof-of-concept for #200. We don't have to stick with anything in this PR; it's simply meant to spark conversation on:
Code
The approach here is to set
d-lg-noneon the existing modal so that it is not used on large screens. And then a differentdivis used to simply show the navbar links for large screens.I referenced the second example in Bootstrap's "Navbar > Responsive behaviors > Toggler" docs.
The example had some code to style the link corresponding to the current page, so I incorporated that too.
Design
For styling, we're just getting whatever Bootstrap gives us. I imagine there might be some opinions about the font. Ultimately, it's up to product/design on that.
Preview
See the preview site for a more complete preview. Here are some screenshots too: