Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SwiftWin32: work towards 32-bit cleanliness #699

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

compnerd
Copy link
Owner

This corrects the type mismatches at a number of sites to make the code
32-bit clean. This is required to enable the use of Swift/Win32 on
32-bit Windows targets.

This corrects the type mismatches at a number of sites to make the code
32-bit clean.  This is required to enable the use of Swift/Win32 on
32-bit Windows targets.
@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #699 (febccda) into main (5dbd402) will decrease coverage by 0.89%.
The diff coverage is 1.25%.

❗ Current head febccda differs from pull request most recent head 2169fa1. Consider uploading reports for the commit 2169fa1 to get more accurate results

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   26.16%   25.27%   -0.90%     
==========================================
  Files         129      130       +1     
  Lines        5121     5334     +213     
==========================================
+ Hits         1340     1348       +8     
- Misses       3781     3986     +205     
Impacted Files Coverage Δ
...iftWin32/App and Environment/ApplicationMain.swift 0.00% <0.00%> (ø)
...urces/SwiftWin32/Text Display and Fonts/Font.swift 14.45% <0.00%> (ø)
...ources/SwiftWin32/Views and Controls/Control.swift 68.10% <0.00%> (ø)
...ces/SwiftWin32/Views and Controls/PickerView.swift 0.00% <0.00%> (ø)
...n32/Views and Controls/Table Views/TableView.swift 0.00% <0.00%> (ø)
...urces/SwiftWin32/Views and Controls/TextView.swift 0.00% <0.00%> (ø)
Sources/SwiftWin32/Support/WinSDK+Extensions.swift 14.28% <10.00%> (ø)
...ources/SwiftWin32/Views and Controls/Stepper.swift 77.33% <50.00%> (ø)
...ources/SwiftWin32/Windows and Screens/Window.swift 26.35% <0.00%> (+5.40%) ⬆️

@compnerd compnerd mentioned this pull request Jun 13, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant