Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for selection of IP version to be used in connecting #331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ppb2020
Copy link

@ppb2020 ppb2020 commented Nov 6, 2024

In preparation for the connectbot Android app to be able to restrict connections to IPv4, added a complement of new connect() methods with different signatures.

  • Kept the versions with the original signatures for backward compatibility.
  • Added a multitude of complement signatures to cover all combinations.
  • Only needed one new signature for connectbot, but nonetheless created all possible combinations of signatures, for completeness.
  • Did not do the same for the initialize() method as it is mostly internal.
  • If backwards compatibility is required for this method as well, a simple change can be made to re-add the original method calling the new one.

As a side note: had to play with Java and Gradle versions to make things work for me during testing. I did not submit these changes as I do not wish to affect the current builds. Hence, the commit herein is missing some of the changes I made during testing and therefore the changes are nominally untested against the current versions. This should not be an issue as the changes are straightforward.

Once this is integrated and the new version is used by connectbot, I have changes to connectbot that will take advantage of one of the new signatures.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Pierre Pierre Blais seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants