query rejection blog post improvement #6949
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlan-z
force-pushed
the
blog-query-rejection
branch
from
4cb8fdd to
3e0fa04
Compare
|
@rajagopalanand Can you also help take a look as rule group rejection is also included in the blog post? |
| @@ -103,9 +103,25 @@ Because this request matches all the configured attributes, it will be blocked. | |||
|
|
|||
| - **Communicate with tenants.** Let affected tenants know if their queries are being blocked, and help them adjust their dashboards accordingly. | |||
|
|
|||
| ## Conclusion | |||
| ## Ruler Queries | |||
There was a problem hiding this comment.
When talking about disabling rule groups, do we want to mention this can be used to prevent rulers from getting OOM killed?
Signed-off-by: Erlan Zholdubai uulu <erlanz@amazon.com>
erlan-z
force-pushed
the
blog-query-rejection
branch
from
3e0fa04 to
feb1c07
Compare
yeya24
approved these changes
Aug 25, 2025
There was a problem hiding this comment.
Thanks! Just one comment. I will let @rajagopalanand take another look
| ## Conclusion | ||
| ## Ruler Queries | ||
|
|
||
| Query rejection only applies to API queries and does not apply to ruler queries. However, Ruler queries are typically instant and lightweight, so a complex query‑rejection mechanism isn’t required for them. |
There was a problem hiding this comment.
I think a big reason here is that rules are scoped by rule group by nature. And it is hard to disable only a single rule in the rule group as other rules can depend on the disabled rule. So support rule group level rejection is sufficient for now.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Improves query rejection blog post.
Ruler Queriespart.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]