-
Notifications
You must be signed in to change notification settings - Fork 828
Override exporter: expose all fields that can be converted to float64 #6979
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: master
Are you sure you want to change the base?
Override exporter: expose all fields that can be converted to float64 #6979
Conversation
91aa01b
to
8c3af7f
Compare
please take a look @bogdan-st |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I don't have much to say other than LGTM
I like to export even default so we can have data of which value is actually configured, but for another point, I am worry about number of metrics that we gonna start generating. Do we want to start exposing all this metrics? Is there a valid cases for this? In cases where we have hundreds or thousands of tenants, this can explode. For prometheus that is not a real problem |
@danielblando |
@SungJin1212 |
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
5027a1c
to
6dda5f8
Compare
@danielblando |
The current
override-exporter
only exposes a limited set of fields. This PR changes the logic to expose all fields that can be converted to afloat64
type.For reviewers: Would it be better to expose only the metrics that have values different from their defaults?
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]