Skip to content

Conversation

SungJin1212
Copy link
Member

@SungJin1212 SungJin1212 commented Aug 19, 2025

The current override-exporter only exposes a limited set of fields. This PR changes the logic to expose all fields that can be converted to a float64 type.

For reviewers: Would it be better to expose only the metrics that have values different from their defaults?

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@dosubot dosubot bot added the type/feature label Aug 19, 2025
@SungJin1212 SungJin1212 force-pushed the Improve-overrides-exporter branch from 91aa01b to 8c3af7f Compare August 19, 2025 12:09
@SungJin1212 SungJin1212 requested a review from friedrichg August 20, 2025 01:04
@friedrichg
Copy link
Member

please take a look @bogdan-st

Copy link
Contributor

@bogdan-st bogdan-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I don't have much to say other than LGTM

@danielblando
Copy link
Contributor

For reviewers: Would it be better to expose only the metrics that have values different from their defaults?

I like to export even default so we can have data of which value is actually configured, but for another point, I am worry about number of metrics that we gonna start generating. Do we want to start exposing all this metrics? Is there a valid cases for this? In cases where we have hundreds or thousands of tenants, this can explode. For prometheus that is not a real problem

@SungJin1212
Copy link
Member Author

@danielblando
I think it's good to expose default values. But since we're exposing the cortex_overrides metric only for tenants registered in the runtime config, I'm wondering if this could cause a series explosion. WDYT?

@danielblando
Copy link
Contributor

@SungJin1212
Ah I missed that. Valid point. I think it is fine then, but it makes sense to not export default if we are just exporting override tenants. If not exported we can assume it is the default i guess

Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the Improve-overrides-exporter branch from 5027a1c to 6dda5f8 Compare August 22, 2025 00:53
@SungJin1212
Copy link
Member Author

@danielblando
Let's go with this for now, and if we need to expose the default later, we can do so.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants