Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[containers, strings, algorithms, re] Use \range where appropriate #7143

Merged
merged 1 commit into from
Mar 15, 2025

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Jul 21, 2024

Currently, there are several cases where \tcode{[i, j)} is used for specifying left-closed right-open intervals, where \range{i}{j} is proper.

@tkoeppe tkoeppe added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 17, 2024
@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 17, 2024

Could you please rebase, use standard commit messages, and report on the result of diffpdf?

@frederick-vs-ja frederick-vs-ja changed the title Use \range where appropriate [containers, strings, algorithms, re] Use \range where appropriate Nov 10, 2024
@frederick-vs-ja
Copy link
Contributor Author

@tkoeppe rebased. Diffpdf result uploaded. diff.pdf

Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.

@jwakely , what do you think?

@frederick-vs-ja , please squash and force-push.

Currently, there are several cases where `\tcode{[i, j)}` is used for
specifying left-closed right-open intervals, where `\range{i}{j}` is proper.

Co-authored-by: Eelis van der Weegen <eelis@eelis.net>
@frederick-vs-ja
Copy link
Contributor Author

@tkoeppe @jensmaurer Rebased and force-pushed.

@tkoeppe
Copy link
Contributor

tkoeppe commented Mar 15, 2025

Thanks!

@tkoeppe tkoeppe merged commit f9847af into cplusplus:main Mar 15, 2025
2 checks passed
@frederick-vs-ja frederick-vs-ja deleted the eelis/range-macro branch March 16, 2025 03:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants