Skip to content

Update ci build scripts #69

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ClausKlein
Copy link
Contributor

build on OS-latest with newest setup-cpp version

ymllint all files

fix typos and strip WS

@ClausKlein ClausKlein marked this pull request as draft September 6, 2023 20:30
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d19d892) 24.70% compared to head (de32c83) 24.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #69   +/-   ##
=======================================
  Coverage   24.70%   24.70%           
=======================================
  Files           6        6           
  Lines         251      251           
  Branches      142      143    +1     
=======================================
  Hits           62       62           
+ Misses        181      159   -22     
- Partials        8       30   +22     
Flag Coverage Δ
Linux 15.74% <ø> (-0.69%) ⬇️
Windows 21.42% <ø> (ø)
macOS 11.65% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lefticus
Copy link
Member

This looks pretty good and does fix MacOS it seems, is there a reason it's still marked as draft? @ClausKlein

@ClausKlein
Copy link
Contributor Author

This looks pretty good and does fix MacOS it seems, is there a reason it's still marked as draft? @ClausKlein

Perhaps to squash it?

build on OS-latest with newest setup-cpp version

ymllint all files

Fix typos and strip WS

Add path to gcovr

Use setup-cpp v0.35.2
@ClausKlein ClausKlein force-pushed the feature/update-ci-builds branch from de32c83 to c5c9c7b Compare March 18, 2024 19:08
@ClausKlein ClausKlein marked this pull request as ready for review March 18, 2024 19:09
@lefticus lefticus changed the base branch from main to develop March 19, 2024 23:09
@lefticus
Copy link
Member

I moved the base to develop then will take another look at these now failing tests again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants