Skip to content

Conversation

tpaulshippy
Copy link
Contributor

What this does

Give callers access to the Faraday response on a property of the Message called "raw"

Type of change

  • New feature

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

API changes

  • New public methods/classes

Related issues

Resolves #301

Copy link
Contributor

@compumike compumike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
@tpaulshippy tpaulshippy changed the title 301: Provide access to raw response object from Faraday Provide access to raw response object from Faraday Jul 29, 2025
Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.54%. Comparing base (e1e9ede) to head (01d3e08).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   85.80%   86.54%   +0.74%     
==========================================
  Files          79       79              
  Lines        3121     3122       +1     
  Branches      598      609      +11     
==========================================
+ Hits         2678     2702      +24     
+ Misses        443      420      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Owner

@crmne crmne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crmne crmne merged commit 1f8865a into crmne:main Jul 30, 2025
15 checks passed
tpaulshippy added a commit to tpaulshippy/ruby_llm that referenced this pull request Aug 3, 2025
## What this does

<!-- Clear description of what this PR does and why -->
Give callers access to the Faraday response on a property of the Message
called "raw"

## Type of change

- [x] New feature

## Scope check

- [x] I read the [Contributing
Guide](https://github.com/crmne/ruby_llm/blob/main/CONTRIBUTING.md)
- [x] This aligns with RubyLLM's focus on **LLM communication**
- [x] This isn't application-specific logic that belongs in user code
- [x] This benefits most users, not just my specific use case

## Quality check

- [x] I ran `overcommit --install` and all hooks pass
- [x] I tested my changes thoroughly
- [x] I updated documentation if needed
- [x] I didn't modify auto-generated files manually (`models.json`,
`aliases.json`)

## API changes

- [x] New public methods/classes

## Related issues

<!-- Link issues: "Fixes crmne#123" or "Related to crmne#123" -->
Resolves crmne#301

---------

Co-authored-by: Mike Robbins <mrobbins@alum.mit.edu>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Access to raw response from LLM
3 participants