Skip to content

Add support for options in FundRawTransaction #121

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

david-garcia-garcia
Copy link

FundRawTransaction has an array of options that was not previously exposed.

Copy link
Contributor

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request! 👍 💯 I left a small comment.

/// <summary>
/// (string, optional, default=pool address) The Bitcoin Cash address to receive the change
/// </summary>
public string changeAddress { set => Data[nameof(changeAddress)] = value; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and all the other properties in this file should start with a capital letter, to be consistent with the rest of the request type declarations.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants