Skip to content

Update examples + check repository health #33

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Conversation

mdpiper
Copy link
Member

@mdpiper mdpiper commented Oct 18, 2024

This PR started as a simple check on the example notebooks, but ended up including some general repository maintenance. The changes:

  1. Dropped support for Python 3.9, added 3.13
  2. Touched up example notebooks, added a launch notebook and a README
  3. Replaced Mambaforge with Miniforge in the CI test workflow, also set an absolute path required for the latest bmi_tester
  4. Applied updated formatting and linting rules from black and ruff

@mdpiper mdpiper changed the title Mdpiper/update examples Update examples + check repository health Oct 18, 2024
@mdpiper
Copy link
Member Author

mdpiper commented Oct 18, 2024

@mcflugen It looks like pre-commit is installed as a GitHub App, but there's no configuration for it. Would you like to ignore this for now, or maybe add it to this PR?

@mcflugen
Copy link
Member

@mcflugen It looks like pre-commit is installed as a GitHub App, but there's no configuration for it. Would you like to ignore this for now, or maybe add it to this PR?

@mdpiper, I added that in #32. To make a cleaner pull request, I've moved those commits to #34.

@mdpiper mdpiper requested a review from mcflugen October 18, 2024 18:50
Copy link
Member

@mcflugen mcflugen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mdpiper mdpiper merged commit 040d072 into master Oct 18, 2024
16 checks passed
@mdpiper mdpiper deleted the mdpiper/update-examples branch October 18, 2024 19:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants