Add a method to retry resolution and pass it to error component #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes running specs a bit neater without being interrupted by warnings
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
=========================================
+ Coverage 94.38% 96.8% +2.42%
=========================================
Files 3 3
Lines 89 94 +5
Branches 25 25
=========================================
+ Hits 84 91 +7
+ Misses 5 3 -2
Continue to review full report at Codecov.
|
This way it can re-attempt resolution to work around network timeouts and such
|
Any updates on this PR? I have the same problem (failed components will never resolve once networking is up again) and I would like to have this feature in the lib. |
|
I implement this as an HOC wrapper around async, to retry with backoff: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use
react-async-componentfor loading web pack modules withimport()and find that they sometimes will timeout or otherwise fail to load.I'd like to add a button to my
ErrorComponentbut there wasn't a way to do so. This provides a function that could be called.I've tested with simulated network timeout by putting Chrome offline and seems to work well.
I also added a spec and noticed a few things that could be improved there. Happy to rework if you spot anything else.