Skip to content

Highlight currently executed instruction in internal editor #138

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

trdthg
Copy link
Contributor

@trdthg trdthg commented Jun 8, 2024

close #124

  • New
    • add Machine::addr_to_blocknum
    • add SampleAsm::address_to_blocknum

when core_step, machine send signal to editor

  • highlight block
  • scroll to block's first line (show in editor middle)

@trdthg trdthg force-pushed the hightlight-running-inst-in-editor branch 3 times, most recently from fd05990 to c3ddbb6 Compare June 9, 2024 10:33
@trdthg trdthg closed this Jun 9, 2024
@trdthg trdthg force-pushed the hightlight-running-inst-in-editor branch from c3ddbb6 to 5e1ee99 Compare June 9, 2024 12:29
@trdthg trdthg reopened this Jun 9, 2024
@trdthg trdthg marked this pull request as ready for review June 9, 2024 13:15
@jdupak jdupak self-requested a review June 10, 2024 20:11
Copy link
Collaborator

@jdupak jdupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good. Good job. But it should be optional. I would like checkboxes in the Options pane to: enable highlighting, and enable focus change. Also a button to trigger the highlight manually would be nice.
One slight nit pick: I would prefer the highlight to cover the whole line (to the right edge of the window), not just the text. To stay consistent with error highlighting.

@jdupak jdupak requested a review from ppisa June 10, 2024 20:22
@trdthg
Copy link
Contributor Author

trdthg commented Jun 12, 2024

  • two options added
  • highlight now cover the block and an extra \n

Also a button to trigger the highlight manually would be nice.

you mean add a button (for enabling highlighting) at the same time?

@trdthg trdthg requested a review from jdupak June 12, 2024 04:03
@jdupak jdupak force-pushed the hightlight-running-inst-in-editor branch from f3282f9 to 6af4d88 Compare June 17, 2024 19:45
@jdupak
Copy link
Collaborator

jdupak commented Jun 17, 2024

It looks very good. I have just changed some texts. But I have noticed one problem - this does not make that much sense in pipelined settings. Could you hook it up to the focus selection in program view?

@trdthg
Copy link
Contributor Author

trdthg commented Jun 18, 2024

fixed, when machine reload, the connect between machine and editor lost

[machine]X -> editor

now rebuild connect between new machine and mainwindow when machine reload:

machine -> mainwindow -> editor

@jdupak jdupak force-pushed the hightlight-running-inst-in-editor branch from c1b0a9d to 74abd75 Compare June 21, 2024 19:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight currently executed instruction in internal editor
2 participants