Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Optimize count queries #239

Open
wants to merge 6 commits into
base: 1.x
Choose a base branch
from
Open

Optimize count queries #239

wants to merge 6 commits into from

Conversation

tntrex
Copy link
Contributor

@tntrex tntrex commented Nov 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #239 (e3099fd) into master (4018f8a) will decrease coverage by 0.02%.
The diff coverage is 90.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #239      +/-   ##
============================================
- Coverage     94.80%   94.78%   -0.03%     
- Complexity      991      998       +7     
============================================
  Files            86       86              
  Lines          2485     2510      +25     
============================================
+ Hits           2356     2379      +23     
- Misses          129      131       +2     
Impacted Files Coverage Δ
src/Select/Loader/ManyToManyLoader.php 95.12% <0.00%> (-2.38%) ⬇️
src/ORM.php 95.00% <100.00%> (ø)
src/Select.php 91.02% <100.00%> (-0.44%) ⬇️
src/Select/AbstractLoader.php 89.36% <100.00%> (-0.30%) ⬇️
src/Select/JoinableLoader.php 90.72% <100.00%> (+0.61%) ⬆️
src/Select/Loader/HasManyLoader.php 100.00% <100.00%> (ø)
src/Select/RootLoader.php 100.00% <100.00%> (ø)
src/RelationMap.php 100.00% <0.00%> (ø)
src/Parser/ArrayNode.php 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4018f8a...e3099fd. Read the comment docs.

@tntrex tntrex marked this pull request as draft November 6, 2021 17:27
@tntrex tntrex changed the title feat(select): use count(PK) if possible Improve primary key for count as default option when possible Nov 6, 2021
@tntrex tntrex marked this pull request as ready for review November 6, 2021 19:03
@tntrex tntrex changed the title Improve primary key for count as default option when possible Use primary key for count queries when possible Nov 7, 2021
@tntrex tntrex changed the title Use primary key for count queries when possible Optimize count queries Dec 6, 2021
@wolfy-j wolfy-j requested a review from roxblnfk February 13, 2024 17:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

1 participant