Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

current scale calculation fix #308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

filip0v
Copy link

@filip0v filip0v commented Nov 27, 2017

Hi dabeng!

I corrected the calculation of the current zoom range, the current implementation does not work for all cases.

For example, for an element with the style transform: rotate (90deg) translateY (-100%) scale (2,2); an incorrect value is returned.

The thing is that the scale must be calculated from the transformation matrix according to the formula (matrix or matrix3d, not important):

scale = Math.sqrt (matrix[0] * matrix[0] + matrix[1] * matrix[1]);

jsfiddle for an example: https://jsfiddle.net/q4hjffwd/

Link with more detailed description about it: https://css-tricks.com/get-value-of-css-rotation-through-javascript/

@filip0v
Copy link
Author

filip0v commented Dec 5, 2017

@dabeng, please consider my pull request

@dabeng
Copy link
Owner

dabeng commented Dec 11, 2017

Thanks a lot. I'm reviewing the PR 😊

@dabeng
Copy link
Owner

dabeng commented Dec 11, 2017

Hi @filip0v , could you review the Djave's comments at the end of the article you mentioned above?

@filip0v
Copy link
Author

filip0v commented Dec 14, 2017

Hi @dabeng, I'll give an answer in a few days.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants