chore: Update to support 0.19 #54
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.19 removes updateTTL from Query. Instead it gets passed into the view factory function. This PR supports both 0.18 and 0.19 by checking the arguments passed to the view factory function. If updateTTL is passed, it is passed to the view. If not, it is taken from the query. Once 0.18 is old enough the workaround can be removed.
|
There is no rush to land this. It can wait until 0.19 is released... Who knows. There might be further changes. |
markusgeert
approved these changes
Apr 14, 2025
| @@ -47,7 +47,7 @@ export function useQuery< | |||
| ) | |||
|
|
|||
| watch(ttl, (ttl) => { | |||
| toValue(query).updateTTL(ttl) | |||
| toValue(view)?.updateTTL(ttl) | |||
There was a problem hiding this comment.
I think we can just do this:
Suggested change
| toValue(view)?.updateTTL(ttl) | |
| view.value?.updateTTL(ttl) |
|
I would wait until 0.19 is done. I'm thinking about his to remove more things from query |
|
marking as draft in the interim - ping me whenever you'd like! 🙏 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.19 removes updateTTL from Query. Instead it gets passed into the view factory function.
This PR supports both 0.18 and 0.19 by checking the arguments passed to the view factory function. If updateTTL is passed, it is passed to the view. If not, it is taken from the query.
Once 0.18 is old enough the workaround can be removed.