Skip to content
This repository was archived by the owner on Oct 4, 2022. It is now read-only.

Bump ibericode/vat to ^2.0 #37

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Restingo
Copy link

Bump ibericode/vat to ^2.0

Closes #22

@Restingo
Copy link
Author

@dannyvankooten do you need sth from my side to merge? Thanks for your work! :-)

@dannyvankooten
Copy link
Owner

@Restingo I'm afraid the PR isn't quite working yet. From a quick glance:

  • The Rates class doesn't resolve right now (namespace is incorrect).
  • The FacadesTest class doesn't run right now because of changed or deleted methods.
  • IIRC correctly, some methods changed names so the README examples would have to be updated as well.

@Restingo
Copy link
Author

@Restingo I'm afraid the PR isn't quite working yet. From a quick glance:

  • The Rates class doesn't resolve right now (namespace is incorrect).
  • The FacadesTest class doesn't run right now because of changed or deleted methods.
  • IIRC correctly, some methods changed names so the README examples would have to be updated as well.

Thanks, I will check.

@Restingo
Copy link
Author

Restingo commented Sep 26, 2022

@dannyvankooten do you have a hint on how to use the Facade as array like the new Countries class?

@dannyvankooten
Copy link
Owner

@Restingo Since the test is about making sure the Facade resolves correctly I would just pick another method on the class to test.

For example:

self::assertEquals((new Countries())->hasCountryCode('NL'), CountriesFacade::hasCountryCode('NL'));

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support ibericode/vat version ^2.0
2 participants