Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I turns out there is a memory leak when we use
Memoize
in combination withtags
.For every new instance we push it's cache map to this array here, this means this array just keeps growing, event if the instance that uses that map may not be used any more (already got garbage collected)
To resolve the issue, instead of saving all these maps in an array under the tag as a key, what we do is we assign each tag a version (a unique symbol), after
clear
is called for a tag, we update the version of the tag.Every time a method is called we compare it's tag version (which we save on a per instance basis), with the latest global tag version, if there is a missmatch it means we need to clear the cache for the instance, and update it's tag version with the latest.
Unfortunately this is a breaking change, as with this implementation there is no way for the
clear
function to return a number any more