Skip to content

Data type Changes #850

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Data type Changes #850

wants to merge 1 commit into from

Conversation

shivamjai17
Copy link

Float is giving warning, To avoid it I changed with np.float.

Copy link
Author

@shivamjai17 shivamjai17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge it

Copy link
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this closing a specific issue? Can you add "closes #xxx" to your opening comment?

@@ -16,6 +16,6 @@
FrameOrSeriesUnion = Union[DataFrame, Series, dd.Series, dd.DataFrame]
SeriesType = Union[dd.Series, Series]
DataFrameType = Union[DataFrame, dd.DataFrame]
Number = Union[int, float, np.float64, np.int64, np.int32]
Number = Union[int, np.float64, np.float64, np.int64, np.int32]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Number = Union[int, np.float64, np.float64, np.int64, np.int32]
Number = Union[int, np.float64, np.int64, np.int32]

np.float64 is already in this list.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closes #850

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants