Add support for "select now() from system.local" #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absurdfarce
commented
Mar 26, 2025
|
|
||
| type Selector interface { | ||
| isSelector() | ||
| Values(columns []*message.ColumnMetadata, valueFunc ValueLookupFunc) (filtered []message.Column, err error) | ||
| Columns(columns []*message.ColumnMetadata, stmt *SelectStatement) (filtered []*message.ColumnMetadata, err error) |
There was a problem hiding this comment.
Even if this weren't fixing the underlying problem the conversion to managing values and columns within selectors rather than as external util functions is worth the cost of admission by itself.
joao-r-reis
approved these changes
Mar 27, 2025
mpenick
approved these changes
Mar 31, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137, at least the bits about adding support for
select now() from system.local. The rest of #137 will be handled in #141.Note that all code contained in this PR was originally written by @mpenick.