Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for "effects" for light (#142) #178

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

martaisty
Copy link
Contributor

Please review and feel free to suggest any good changes 🙂
The PR closes issue #142

Changes:

  • Added support for effects for HALight
  • Updated light example with effects usage
  • Covered new code with Unit tests
  • Updated existing documentation to include effects feature

@martaisty martaisty marked this pull request as ready for review July 23, 2023 16:11
@NekoCWD
Copy link

NekoCWD commented Jan 3, 2024

Thank you for your work

@martaisty
Copy link
Contributor Author

martaisty commented Feb 10, 2024

Hi @dawidchyrzynski 👋 The PR is ready for review.
BTW I had an issue with generating docs from sources, therefore feel free to regenerate it if needed.

P.S.: I managed to generate docs. However, it seems to me that Pipfile might be broken (#231)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants