Increased usage of PROGMEM string #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defined at compile time this time with `ARDUINOHA_MAXPROGMEM_STRINGS` define Saves a good chunk of memory No breaking change
bennydiamond
force-pushed
the
Flash-strings-step-2
branch
from
4b17562
to
325e083
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even more flash strings.
In my project, it saved me 154 bytes of memory (10 binary sensors with minimal setup).
Defined at compile time this time with
ARDUINOHA_MAXPROGMEM_STRINGSdefineI originally wanted to go for something dynamic but using a global defined macro is cleaner (and easier!)
Feel free to suggest define names. I'm bad at coming up with names.
Saves a good chunk of memory
No breaking change
Tested on my custom project, only with BinarySensor devices tho...