Skip to content

chore: remove webpack-sources #73

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

yoyo837
Copy link

@yoyo837 yoyo837 commented Sep 15, 2022

  1. Remove webpack-sources;
  2. fix github:dcasia/digital-creative-eslint-plugin not founded.

ref: #62 #72

Copy link
Contributor

@ItsRyanWu ItsRyanWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这么做无法兼容 webpack v4 因为 v4 没有 import { sources } from 'webpack' 中 sources 这个对象,当初就是因为考虑到这个才引入了 webpack-sources 且仅会在 webpack v4 时使用,v5 时使用 webpack 内置的。目前我觉得我可以做的就是升级 webpack-sources。

@yoyo837
Copy link
Author

yoyo837 commented Apr 21, 2023

peer依赖吧? 如何?

@ItsRyanWu
Copy link
Contributor

peer依赖吧? 如何?

可以请教下为什么 peerDependencies 可以解决问题吗?另外还有一点比较疑惑,当 webpack 版本为 v5 时程序会自动使用 webpack 内的 sources 对象而非 webpack-sources 库里的,如果是这样的话问题为什么会发生呢?

@yoyo837
Copy link
Author

yoyo837 commented Apr 21, 2023

peer依赖吧? 如何?

可以请教下为什么 peerDependencies 可以解决问题吗?另外还有一点比较疑惑,当 webpack 版本为 v5 时程序会自动使用 webpack 内的 sources 对象而非 webpack-sources 库里的,如果是这样的话问题为什么会发生呢?

因为Taro那边可能也是为了考虑webpack4的兼容, 导致版本冲突, 因为这样 #72 (comment) 是可以解决的

peerDependencies 依赖的话也要比较新才行.

@ItsRyanWu ItsRyanWu changed the base branch from development to 220421 April 21, 2023 11:06
@ItsRyanWu ItsRyanWu changed the base branch from 220421 to development April 21, 2023 11:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants