-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
animation: add animation exclude #35
base: implement-window-animations
Are you sure you want to change the base?
animation: add animation exclude #35
Conversation
animation: add animation_opacity_min, for reduce flicker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contributions!
The blacklist code looks great.
The code for the minimum opacity looks good too, but I question its inclusion. Why do you think it is necessary/desirable? It seems to me that it is a workaround for #19, which isn't necessarily bad, but if that's the case, it does not tackle the root cause at all -- and that's bad. Sorry, I didn't properly read your last message. What do you mean by "flicker"? (The point about the root cause probably still stands, though.)
About flicker, I can show you gif. // Only animate opacity here if we are resizing
// a transparent window
process_window_for_painting(ps, w, w->win_image,
w->opacity >= 1 ? 1.0 : w->animation_progress,
®_bound, ®_visible,
®_paint, ®_paint_in_bound);
// Only do this if size changes as otherwise moving
// transparent windows will flicker and if you just
// move so slightly they will keep flickering
if (resizing) {
process_window_for_painting(ps, w, w->old_win_image,
1.0 - w->animation_progress,
®_bound, ®_visible,
®_paint, ®_paint_in_bound);
} When window be moving slightly, animation_progress always loop between 0 to 1. (xserver continuously send moving requests) |
Update? |
yep, I had use my fork version 1month. It nice working. |
Why did you close this? I didn't reject your work, I just hadn't gotten around to looking at it again. |
oooo,I want to fork another version picom FT-Labs/picom but github allow only one repo to fork this. so I delete my fork repo. and fork new one. Maybe tonight I create a new pr to you |
Cool, I need this feature! Could I ask when will we merge this PR? @dccsillag |
Looking forward to this feature, I don't want my fcitx to zoom again and again when typing |
用我仓库那版本得了。这边估计是不会合的了 |
I hope some window not use animation, for example fcitx.
so I make this pr