Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

animation: add animation exclude #35

Open
wants to merge 3 commits into
base: implement-window-animations
Choose a base branch
from
Open

animation: add animation exclude #35

wants to merge 3 commits into from

Conversation

yaocccc
Copy link

@yaocccc yaocccc commented Jun 11, 2022

I hope some window not use animation, for example fcitx.
so I make this pr

@yaocccc
Copy link
Author

yaocccc commented Jun 11, 2022

animation: add animation_opacity_min, for reduce flicker

Copy link
Owner

@dccsillag dccsillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions!

The blacklist code looks great.

The code for the minimum opacity looks good too, but I question its inclusion. Why do you think it is necessary/desirable? It seems to me that it is a workaround for #19, which isn't necessarily bad, but if that's the case, it does not tackle the root cause at all -- and that's bad. Sorry, I didn't properly read your last message. What do you mean by "flicker"? (The point about the root cause probably still stands, though.)

@yaocccc
Copy link
Author

yaocccc commented Jun 12, 2022

Thank you for your contributions!

The blacklist code looks great.

The code for the minimum opacity looks good too, but I question its inclusion. Why do you think it is necessary/desirable? It seems to me that it is a workaround for #19, which isn't necessarily bad, but if that's the case, it does not tackle the root cause at all -- and that's bad. Sorry, I didn't properly read your last message. What do you mean by "flicker"? (The point about the root cause probably still stands, though.)

About flicker, I can show you gif.
show

// Only animate opacity here if we are resizing
// a transparent window
process_window_for_painting(ps, w, w->win_image,
	w->opacity >= 1 ? 1.0 : w->animation_progress,
	&reg_bound, &reg_visible,
	&reg_paint, &reg_paint_in_bound);

// Only do this if size changes as otherwise moving 
// transparent windows will flicker and if you just
// move so slightly they will keep flickering
if (resizing) {
         process_window_for_painting(ps, w, w->old_win_image,
	 1.0 - w->animation_progress,
	 &reg_bound, &reg_visible,
	&reg_paint, &reg_paint_in_bound);
}

When window be moving slightly, animation_progress always loop between 0 to 1. (xserver continuously send moving requests)

@RaafatTurki
Copy link

Update?
This is a really important piece as some programs are pretty much unusable with animations.

@yaocccc yaocccc requested a review from dccsillag July 10, 2022 15:16
@yaocccc
Copy link
Author

yaocccc commented Aug 9, 2022

Update? This is a really important piece as some programs are pretty much unusable with animations.

yep, I had use my fork version 1month. It nice working.
Maybe you can use my fork verison

@yaocccc yaocccc closed this by deleting the head repository Sep 19, 2022
@dccsillag
Copy link
Owner

Why did you close this? I didn't reject your work, I just hadn't gotten around to looking at it again.

@yaocccc
Copy link
Author

yaocccc commented Sep 19, 2022

Why did you close this? I didn't reject your work, I just hadn't gotten around to looking at it again.

oooo,I want to fork another version picom FT-Labs/picom

but github allow only one repo to fork this.

so I delete my fork repo. and fork new one.

Maybe tonight I create a new pr to you

@yaocccc yaocccc reopened this Sep 19, 2022
@XXiaoA
Copy link

XXiaoA commented Apr 2, 2023

Cool, I need this feature! Could I ask when will we merge this PR? @dccsillag

@LAST7
Copy link

LAST7 commented Jun 20, 2023

Looking forward to this feature, I don't want my fcitx to zoom again and again when typing

@yaocccc
Copy link
Author

yaocccc commented Jun 21, 2023

Looking forward to this feature, I don't want my fcitx to zoom again and again when typing

用我仓库那版本得了。这边估计是不会合的了

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants