Merge upstream #47
Open
Merge upstream #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a typo in the man docs
If the config file is loaded from a symlink'd locaiton, it could be confusing that include dir is set based on the location of the symlink instead of the real file. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
GCC warns about a use after free, because a pointer is used in pointer comparison after it was freed. This particular case is completely safe, but GCC warns anyway. Move the free after the comparison requires me duplicating the free a couple of times, so instead I made use of the cleanup attribute to auto free the pointer when it goes out of scope. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
trim_both removes whitespaces from both side of a string. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Also renames free_wincondlst to c2_list_free and move it to c2.h. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Useful for error handling. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Used for setting custom window shaders and rules for choosing custom window shaders. Added a "c2_userdata_free" parameter to c2_list_free, so allocated userdata stored in nodes can be freed. Signed-off-by: Bernd Busse <bernd@busse-net.de> Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Current this API can only create shader from a single source file. This could be changed in the future. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Used for passing back information about whether a shader needs to be re-rendered every frame. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
I also noticed there is an opportunity to unify fades, animated shaders, and the benchmark mode. We should be able to get rid of the fade timer. A TODO for the future. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
gl_common.c is getting too big. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Instead of always using the back texture/fbo. Also use the size of the source texture, instead of hard coded back buffer size. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Using integral to estimate the sum of the kernel will overestimate a little bit. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Since image_dst is in X coordinates, after flipping Y, we need to subtract the height of the drawing area, to make it the bottom right corner for OpenGL. However, this breaks blur. Because we assumed the drawing area is the same size as the texture, which is not the case for blur. So add the height of the drawing area as another parameter. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
If the backend implements shadow_from_mask then it doesn't need to implement render_shadow. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Do this for shaped, and rounded windows. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Fix blur behind rounded corner windows
dual kawase is fast but its blur size is coarse grained, which sometimes makes the shadow ugly. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
mochaaP
force-pushed
the
dccsillag-next
branch
from
598f604 to
6ce9e68
Compare
mochaaP
force-pushed
the
dccsillag-next
branch
from
6ce9e68 to
db2f884
Compare
|
Build passed and runs. However there's two problems:
|
This needs the EGL_KHR_image_pixmap and the GL_EXT_EGL_image_storage extensions, which unfortunately aren't available on NVIDIA cards. Don't add documentation for these, for now. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Add an experimental egl backend
Destroy context and surface as well in egl_deinit. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
clang does not recognize the fallthrough annotation used in uthash.h, so we change -Wimplicit-fallthrough to the single argument form currently only supported by GCC. We are still detecting implicit fallthroughs with GCC in CI. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Related: yshui#905 Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.