show team in status #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
reviewed
Jan 6, 2023
| @@ -470,7 +470,7 @@ def printPlayers(server, filt, con, cur): | |||
| else: | |||
| htmlName = escape(player['name']) | |||
|
|
|||
| print((u" <td class=\"time\">%s</td><td class=\"name\">%s</td><td class=\"clan\">%s</td><td class=\"flag\"><img src=\"countryflags/%s.png\" alt=\"%s\" height=\"20\"/></td>" % (formatScore(player['score'], "race" not in server['game_type'].lower()), htmlName, escape(player['clan']), countryFlags.get(player['country'], 'default'), countryFlags.get(player['country'], 'NONE'))).encode('utf-8')) | |||
| print((u" <td class=\"time\">%s</td><td class=\"team\">Team %s</td><td class=\"name\">%s</td><td class=\"clan\">%s</td><td class=\"flag\"><img src=\"countryflags/%s.png\" alt=\"%s\" height=\"20\"/></td>" % (formatScore(player['score'], "race" not in server['game_type'].lower()), escape(player["team"]), htmlName, escape(player['clan']), countryFlags.get(player['country'], 'default'), countryFlags.get(player['country'], 'NONE'))).encode('utf-8')) | |||
There was a problem hiding this comment.
Is that really useful? Most will show team 0 anyway. Will take a lot of space
There was a problem hiding this comment.
probs not, maybe we could color them? and the team 0 color is just invisible
There was a problem hiding this comment.
Colored text would look bad, background color would be ok.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.