Skip to content

implement endpoints #20

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 61 additions & 15 deletions src/routes/pokemon.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,32 +7,78 @@ router.get("/", function (req, res, next) {
res.json(pokedex);
});


/* GET Pokemon by HP */
router.get('/hp', function (req, res, next) {
const validQueries = ['lt', 'lte', 'gt', 'gte']

if (Object.keys(req.query).every(query => !validQueries.includes(query))) {
return res.status(400).json({
message: 'Invalid Operator. Must be one of ["gt","gte","lt","lte"]',
});
}
const { lt, lte, gt, gte } = req.query;

const pokemon = pokedex.filter(pokemon => {
if (lt != null) {
return pokemon.base.HP < lt;
} else if (lte != null) {
return pokemon.base.HP <= lte;
} else if (gt != null) {
return pokemon.base.HP > gt;
} else if (gte != null) {
return pokemon.base.HP >= gte;
}
return;
});
if (pokemon.length !== 0) {
return res.json(pokemon);
}
res.status(404).json({ message: 'Not found' });
return;
});

/* GET Pokemon by Id. */
router.get("/:id", function (req, res, next) {
// TODO: Implement this route. See swagger docs for details, by visiting http://localhost:3000/api-docs
res.status(501).json({ message: "Not Implemented" });
router.get('/:id', function (req, res, next) {
const id = Number(req.params.id);
if (isNaN(id)) {
return res.status(400).json({ message: 'Invalid ID' });
}
const pokemon = pokedex.find(pokemon => pokemon.id === id);
if (pokemon != null) {
return res.json(pokemon);
}
res.status(404).json({ message: 'Not found' });
return;
});

/* GET Pokemon by English Name */
router.get("/name/:name", function (req, res, next) {
// TODO: Implement this route. See swagger docs for details, by visiting http://localhost:3000/api-docs
res.status(501).json({ message: "Not Implemented" });
router.get('/name/:name', function (req, res, next) {
const name = req.params.name;

const pokemon = pokedex.find(
pokemon => pokemon.name.english.toLowerCase() === name.toLowerCase()
);
if (pokemon != null) {
return res.json(pokemon);
}
res.status(404).json({ message: 'Not found' });
return;
});

/* GET Pokemon by Type */
router.get("/type/:type", function (req, res, next) {
// TODO: Implement this route. See swagger docs for details, by visiting http://localhost:3000/api-docs
res.status(501).json({ message: "Not Implemented" });
return;
});
router.get('/type/:type', function (req, res, next) {
const type = req.params.type;

/* GET Pokemon by HP */
router.get("/hp", function (req, res, next) {
// TODO: Implement this route. See swagger docs for details, by visiting http://localhost:3000/api-docs
res.status(501).json({ message: "Not Implemented" });
const pokemon = pokedex.filter(pokemon =>
pokemon.type.some(t => t.toLowerCase() === type.toLowerCase())
);
if (pokemon.length !== 0) {
return res.json(pokemon);
}
res.status(400).json({ message: 'Bad request' });
return;
});


module.exports = router;