Skip to content

Avoid using .textContent #31

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid using .textContent #31

wants to merge 1 commit into from

Conversation

developit
Copy link
Owner

@danielweck
Copy link

Indeed, .textContent is an order of magnitude slower. Apart from the code conflicts, is there anything blocking this PR? This is a pretty straight-forward and safe change, as you are checking n.nodeType === 3 (Text node, which is CharacterData and therefore has the data property).

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@developit @danielweck