Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Table of contents #689

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

ATL2001
Copy link
Contributor

@ATL2001 ATL2001 commented Oct 18, 2024

I've added the code for making a table of contents to the lonboard controls module, which seemed like the best place to put it to me.

I need to plead ignorance on the typing of the lonboard_map parameter of the make_TOC() function. I honestly don't have any idea how to get the lonboard.Map to be the type without causing a circular import error in the package. hopefully someone can help me out there!

For simplicity's sake, I've made the example notebook for the new functionality use as simple of geodataframes/layers as possible. hopefully that's ok.

@kylebarron
Copy link
Member

Sorry @ATL2001 , I've been head-down on other projects the last few days, like https://github.com/developmentseed/object-store-rs. I'll review this in the next couple days 🙏

@ATL2001
Copy link
Contributor Author

ATL2001 commented Oct 21, 2024

I totally understand that feeling. No worries, I actually don’t even have a use case currently for this personally, I see it’s usefulness and just figured I could help out a bit 😀(I had tinkered with something like this a while back, and just needed to abstract it a bit/ wire it into the codebase).

If you or anyone else has any ideas how we could make a widget for the traits that are None when the TOC is created that would be great. I messed around with using an unchecked checkbox on initialization, but didn’t like the interactivity of it then disappearing and replacing it with another widget, it felt very hacky

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants