Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: resizable array buffer close gh-37 #38

Closed
wants to merge 1 commit into from

Conversation

Jack-Works
Copy link
Contributor

close #37

@brettz9
Copy link
Collaborator

brettz9 commented Sep 21, 2024

Thanks for the report and PR! I hadn't seen your PR and started #39 . I've added a fix for the ArrayBuffer type too. But running into your same issue in CI for Node 18. The Node 22 issue is I think that mentioned at #24 (comment)

If you want to review, I think we can nevertheless merge the changes, as I think they are indeed necessary.

@brettz9
Copy link
Collaborator

brettz9 commented Sep 21, 2024

The Node 18 failure was due to CI using an older version of Node. I've adjusted CI, though not sure if a bump in engines is needed too.

In any case, closing in favor of #39 . Thanks again!

@brettz9 brettz9 closed this Sep 21, 2024
@Jack-Works Jack-Works deleted the resizable branch September 22, 2024 03:16
@Jack-Works
Copy link
Contributor Author

thanks! happy to see that fixed

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change: maxByteLength in ArrayBuffer
2 participants