-
Notifications
You must be signed in to change notification settings - Fork 57
Graphviz #644
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Graphviz #644
Conversation
TODO:
|
b35efd9
to
d4b6e10
Compare
19fe156
to
5416f88
Compare
The CI will likely fail here until: is merged. |
This might be a bit much for this week, but maybe not. |
5416f88
to
a236436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool!
@@ -0,0 +1,27 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is autogenerated and is listed in .gitignore
and should not be included in the repo.
<#GAPDoc Label="GraphvizVertexLabelledDigraph"> | ||
<ManSection> | ||
<Attr Name="GraphvizVertexLabelledDigraph" Arg="D"/> | ||
<Attr Name="GraphvizVertexLabelledGraph" Arg="D"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, I was wishing we had such a function already yesterday.
<Description> | ||
These functions produce &graphviz; objects representing the digraph | ||
<A>D</A>, where the vertices in the list <A>verts</A>, and edges | ||
between them, are drawn with color <A>color1</A> and all other vertices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the text of the Digraphs manual, we sometimes use the US spelling color
and sometimes we use the British spelling colour
. I suggest we standardise at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be removed, presumably it's just a vestige?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file can be removed, presumably it's just a vestige?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file part of this PR? Should it be a separate one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This stuff looks nice so far, although it's obviously got a few TODOs etc, but this should eventually be its own PR too.
This is a reworking of #639, which goes a bit further than #639 in removing the old stuff for displays. This PR doesn't introduce any breaking changes except that we now require the
graphviz
package. So this PR shouldn't be merged until there is a release of `graphviz'.