feat: pre-commit hook #7428
Open
feat: pre-commit hook #7428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
commented
Mar 17, 2025
Lulalaby
commented
Mar 17, 2025
| npm run fix:tables | ||
| npm run test:links | ||
| npm run test:build | ||
| git update-index --again |
There was a problem hiding this comment.
We might not need to run test:build here in the pre-commit, since it generates a big chunk of text while committing, and we already run that in the CI
Lulalaby
force-pushed
the
pre-commit-hook/fix-tables
branch
from
36e73ea to
46c964c
Compare
Not sure if this is actually needed, doing a separate commit to ensure we can revert this easily.
ckohen
reviewed
Mar 19, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more headache when working with tables
Details
Uses: https://typicode.github.io/husky/ (https://github.com/typicode/husky)
Runs on:
git commitWill be skipped on ci-runs
Runs:
fix:tables,test:links&test:build(For Colin :D)
Notes
test:linksfails. It only outputs that there's an error. But this is intended since the CI should block that."prepare": "npx is-ci || npx husky"is-ciwill be true if executed on github actions, skipping the husky run if neededgit update-index --againis added to.husky/pre-committo commit the fixed tablestest:build